Pass options as keywords during block extraction#521
Merged
lessthanjacob merged 4 commits intoprocore-oss:mainfrom Feb 25, 2026
Merged
Pass options as keywords during block extraction#521lessthanjacob merged 4 commits intoprocore-oss:mainfrom
lessthanjacob merged 4 commits intoprocore-oss:mainfrom
Conversation
jhollinger
force-pushed
the
keyword-field-options
branch
from
1c21c38 to
cf57240
Compare
lessthanjacob
previously approved these changes
Jul 8, 2025
jhollinger
previously approved these changes
Jul 22, 2025
tylerhunt
force-pushed
the
keyword-field-options
branch
from
cf57240 to
fb7fb0c
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Tyler Hunt <tyler@tylerhunt.com>
tylerhunt
force-pushed
the
keyword-field-options
branch
from
9140d9d to
e724c32
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
tylerhunt
dismissed stale reviews from jhollinger and lessthanjacob
via
2f9b820
Contributor
Author
|
Merged upstream. Looks like that dismissed the reviews. Any blocker to getting this merged? |
Contributor
|
@tylerhunt Apologies for the delay here! Once the checks pass, I'll go ahead and merge this. |
Contributor
|
@tylerhunt not quite sure why it's picking up |
lessthanjacob
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows field definitions to use keyword options for blocks: